Skip to content

chore(android): address Gradle 9.0 deprecation warnings #2534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

chore(android): address Gradle 9.0 deprecation warnings #2534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,17 @@ project.ext.react = [
project.ext.signingConfigs = getSigningConfigs()

android {
namespace "com.microsoft.reacttestapp"
namespace = "com.microsoft.reacttestapp"

compileSdkVersion project.ext.compileSdkVersion
compileSdkVersion = project.ext.compileSdkVersion

if (project.hasProperty("ndkVersion")) {
ndkVersion project.ext.ndkVersion
ndkVersion = project.ext.ndkVersion
}

if (usePrefabs) {
buildFeatures {
prefab true
prefab = true
}
}

Expand All @@ -89,34 +89,34 @@ android {
}

defaultConfig {
applicationId project.ext.react.applicationId
minSdkVersion project.ext.minSdkVersion
targetSdkVersion project.ext.targetSdkVersion
versionCode project.ext.getVersionCode()
versionName project.ext.getVersionName()
applicationId = project.ext.react.applicationId
minSdkVersion = project.ext.minSdkVersion
targetSdkVersion = project.ext.targetSdkVersion
versionCode = project.ext.getVersionCode()
versionName = project.ext.getVersionName()

def singleApp = getSingleAppMode()
buildConfigField "String", "REACTAPP_SINGLE_APP", singleApp ? "\"${singleApp}\"" : "null"
buildConfigField("String", "REACTAPP_SINGLE_APP", singleApp ? "\"${singleApp}\"" : "null")

buildConfigField "boolean", "REACTAPP_USE_FABRIC", enableNewArchitecture.toString()
buildConfigField "boolean", "REACTAPP_USE_BRIDGELESS", enableBridgeless.toString()
buildConfigField("boolean", "REACTAPP_USE_FABRIC", enableNewArchitecture.toString())
buildConfigField("boolean", "REACTAPP_USE_BRIDGELESS", enableBridgeless.toString())

manifestPlaceholders = [
rntaEnableCamera: project.ext.react.enableCamera ? "1000000" : "1"
]

resValue "string", "app_name", project.ext.react.appName
resValue("string", "app_name", project.ext.react.appName)

def cppStd = reactNativeVersion >= v(0, 74, 0) ? "-std=c++20" : "-std=c++17"
if (enableNewArchitecture) {
externalNativeBuild {
cmake {
arguments "-DANDROID_STL=c++_shared",
arguments("-DANDROID_STL=c++_shared",
"-DNODE_MODULES_DIR=${reactNativePath}/..",
"-DPROJECT_BUILD_DIR=${buildDir}",
"-DREACT_ANDROID_BUILD_DIR=${reactNativePath}/ReactAndroid/build",
"-DREACT_ANDROID_DIR=${reactNativePath}/ReactAndroid"
cppFlags cppStd, "-frtti", "-fexceptions", "-DWITH_INSPECTOR=1"
"-DREACT_ANDROID_DIR=${reactNativePath}/ReactAndroid")
cppFlags(cppStd, "-frtti", "-fexceptions", "-DWITH_INSPECTOR=1")
}
}
if (!project.ext.react.abiSplit) {
Expand All @@ -127,18 +127,18 @@ android {
} else {
externalNativeBuild {
cmake {
arguments "-DANDROID_STL=c++_shared",
arguments("-DANDROID_STL=c++_shared",
"-DREACT_COMMON_DIR=${reactNativePath}/ReactCommon",
"-DREACT_JNILIBS_DIR=${buildDir}/outputs/jniLibs"
cppFlags cppStd, "-Wall", "-Werror", "-frtti", "-fexceptions", "-DWITH_INSPECTOR=1"
"-DREACT_JNILIBS_DIR=${buildDir}/outputs/jniLibs")
cppFlags(cppStd, "-Wall", "-Werror", "-frtti", "-fexceptions", "-DWITH_INSPECTOR=1")
}
}
}
}

externalNativeBuild {
cmake {
path "${projectDir}/src/main/jni/CMakeLists.txt"
path = "${projectDir}/src/main/jni/CMakeLists.txt"
}
}

Expand All @@ -165,14 +165,14 @@ android {
}

lintOptions {
lintConfig file("lint.xml")
lintConfig = file("lint.xml")
}

packagingOptions {
pickFirst "lib/armeabi-v7a/libc++_shared.so"
pickFirst "lib/arm64-v8a/libc++_shared.so"
pickFirst "lib/x86_64/libc++_shared.so"
pickFirst "lib/x86/libc++_shared.so"
pickFirst("lib/armeabi-v7a/libc++_shared.so")
pickFirst("lib/arm64-v8a/libc++_shared.so")
pickFirst("lib/x86_64/libc++_shared.so")
pickFirst("lib/x86/libc++_shared.so")
}

project.ext.signingConfigs.each { name, config ->
Expand Down Expand Up @@ -244,8 +244,8 @@ android {
splits {
abi {
reset()
enable(project.ext.react.abiSplit)
universalApk(false)
enable = project.ext.react.abiSplit
universalApk = false
include(*project.ext.react.architectures)
}
}
Expand All @@ -271,15 +271,15 @@ dependencies {
implementation("com.facebook.react:react-native:${version}")
}

implementation libraries.androidAppCompat
implementation libraries.androidCoreKotlinExtensions
implementation libraries.androidRecyclerView
implementation libraries.materialComponents
implementation(libraries.androidAppCompat)
implementation(libraries.androidCoreKotlinExtensions)
implementation(libraries.androidRecyclerView)
implementation(libraries.materialComponents)

if (project.ext.react.enableCamera) {
implementation libraries.androidCamera
implementation libraries.androidCameraMlKitVision
implementation libraries.mlKitBarcodeScanning
implementation(libraries.androidCamera)
implementation(libraries.androidCameraMlKitVision)
implementation(libraries.mlKitBarcodeScanning)
}

if (reactNativeVersion == 0 || reactNativeVersion >= v(0, 75, 0)) {
Expand Down
16 changes: 8 additions & 8 deletions android/support/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,22 @@ repositories {
}

android {
namespace "com.microsoft.reacttestapp.support"
namespace = "com.microsoft.reacttestapp.support"

def androidDir = "${buildscript.sourceFile.getParent()}/../"
apply(from: "${androidDir}/dependencies.gradle")

compileSdkVersion project.ext.compileSdkVersion
compileSdkVersion = project.ext.compileSdkVersion

defaultConfig {
minSdkVersion project.ext.minSdkVersion
targetSdkVersion project.ext.targetSdkVersion
versionCode getVersionCode()
versionName getVersionName()
minSdkVersion = project.ext.minSdkVersion
targetSdkVersion = project.ext.targetSdkVersion
versionCode = getVersionCode()
versionName = getVersionName()
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}
}
2 changes: 1 addition & 1 deletion example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ allprojects {
def p = searchDir.resolve("node_modules/react-native/android")
if (p.toFile().exists()) {
maven {
url(p.toRealPath().toString())
url = p.toRealPath().toString()
}
break
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/template.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function buildGradle() {
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" maven {",
" url(p.toRealPath().toString())",
" url = p.toRealPath().toString()",
" }",
" break",
" }",
Expand Down
4 changes: 2 additions & 2 deletions test/configure/gatherConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe("gatherConfig()", () => {
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" maven {",
" url(p.toRealPath().toString())",
" url = p.toRealPath().toString()",
" }",
" break",
" }",
Expand Down Expand Up @@ -485,7 +485,7 @@ describe("gatherConfig()", () => {
' def p = searchDir.resolve("node_modules/react-native/android")',
" if (p.toFile().exists()) {",
" maven {",
" url(p.toRealPath().toString())",
" url = p.toRealPath().toString()",
" }",
" break",
" }",
Expand Down
Loading