Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup & Flyout samples! #397

Closed
omdxp opened this issue Mar 1, 2021 · 5 comments
Closed

Popup & Flyout samples! #397

omdxp opened this issue Mar 1, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request samples
Milestone

Comments

@omdxp
Copy link

omdxp commented Mar 1, 2021

Hello, it would be a great deal if you show us how to use Flyout or Popup. I am trying to use them but I don't know what to give to the target prop. Can you help us with one sample showing us how to use them?

@ghost ghost added the Needs: Triage 🔍 label Mar 1, 2021
@chrisglein
Copy link
Member

chrisglein commented Mar 1, 2021

@chiaramooney thoughts on adding these components to React Native Gallery? It likely isn't necessary to add specific sample apps just for these and covering in gallery is enough.

There's content in RNTester that could become Gallery friendly and less internal. Glyph is another... keyboard stuff... etc.

If we open an issue on the Gallery repo we can close this out against that.

@chrisglein chrisglein added enhancement New feature or request samples and removed Needs: Triage 🔍 labels Mar 1, 2021
@chrisglein chrisglein added this to the Backlog milestone Mar 1, 2021
@chiaramooney
Copy link
Collaborator

chiaramooney commented Mar 2, 2021

Gallery actually already has pages for both of these!
See issue: here
PR: Flyout, Popup

@omdxp
Copy link
Author

omdxp commented Mar 2, 2021

Gallery actually already has pages for both of these!
See issue: here
PR: Flyout, Popup

@chiaramooney why use these instead of using Modal directly from react-native?

@asklar
Copy link
Member

asklar commented Mar 2, 2021

@Omar-Belghaouti we don't yet support Modal (I believe this is a more recent control?). Work to add it is tracked by microsoft/react-native-windows#2989

@omdxp
Copy link
Author

omdxp commented Mar 2, 2021

Thanks @asklar we'd love to use Modal so we get the real experience of the cross platform application 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request samples
Projects
None yet
Development

No branches or pull requests

4 participants