Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Modal #2989

Closed
11 tasks
kmelmon opened this issue Aug 23, 2019 · 15 comments
Closed
11 tasks

Implement Modal #2989

kmelmon opened this issue Aug 23, 2019 · 15 comments
Labels
API: Completion enhancement Partner: 3P 3rd party customer asks Recommend: Not Planned Recommend that issue should be given Not Planned milestone. Story: ⚖ Parity Be a 1st class RN platform (which means supporting most of its APIs)
Milestone

Comments

@kmelmon
Copy link
Contributor

kmelmon commented Aug 23, 2019

Summary

vnext has not yet implemented Modal. See https://facebook.github.io/react-native/docs/modal

  • visible
  • supportedOrientations
  • onRequestClose
  • onShow
  • transparent
  • animationType
  • hardwareAccelerated
  • onDismiss
  • onOrientationChange
  • presentationStyle
  • animated
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 23, 2019
@chrisglein chrisglein self-assigned this Aug 26, 2019
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 26, 2019
@chrisglein chrisglein added this to the vNext Milestone 3 milestone Aug 26, 2019
@chrisglein
Copy link
Member

Moving to track this on a project board: https://github.com/microsoft/react-native-windows/projects/22

@chrisglein
Copy link
Member

Not in lean core, moving out to M5.

@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 9, 2020
@exotexot
Copy link

exotexot commented Jun 8, 2020

Would enjoy having Modals in RNW :)

@ryfow
Copy link
Contributor

ryfow commented Sep 11, 2020

Another vote from me. This has been the most annoying part of porting our app to Windows by far.

@exotexot
Copy link

Having had the same issue, I used https://microsoft.github.io/react-native-windows/docs/flyout-component those which behaves very similarly to Modal components.

@chrisglein chrisglein added the Partner: 3P 3rd party customer asks label Sep 14, 2020
@chrisglein
Copy link
Member

@gillpeacegood You had some need for this. Can you list what features you need from Modal so we can go after this with the right prioritization. It's not yet currently implemented.

@chrisglein chrisglein modified the milestones: Backlog, 0.65 Sep 14, 2020
@gillpeacegood
Copy link
Contributor

I've had to back fill it with a JS library (react-native-root-modal). It would have been good to have known about it from the feature parity documentation https://microsoft.github.io/react-native-windows/docs/parity-status

@chrisglein chrisglein assigned asklar and unassigned chrisglein Sep 23, 2020
@asklar
Copy link
Member

asklar commented Sep 24, 2020

@chrisglein do we know what APIs we need? there is a modal component in core and a community module too. The community module has a lot more APIs. It will be good to understand prioritization.

@capc0
Copy link

capc0 commented Nov 12, 2020

Modal support would be great. In our case we need it to implement a layover-style loadingspinner that prevents all touch events while its visible.

@chrisglein chrisglein modified the milestones: 0.65, 0.66 Apr 24, 2021
@chrisglein chrisglein modified the milestones: 0.66, Backlog Aug 2, 2021
@chrisglein chrisglein added the Story: ⚖ Parity Be a 1st class RN platform (which means supporting most of its APIs) label Aug 9, 2021
@SBS-olessia
Copy link

Is there an ETA for when modals for windows might be implemented?

@acaininet
Copy link

Seems like many packages use Modal to implement common modern controls. What is the roadmap for Modal? Or is there a current workaround?

@ohzak
Copy link

ohzak commented Feb 16, 2023

nice to notice how this matter is substantially ignored since 4 or even more years, while nowadays modals are utilized everywhere XD

@exotexot
Copy link

#2989 (comment)

@jonthysell
Copy link
Contributor

Related: #11157

@chrisglein chrisglein added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 30, 2023
@chrisglein
Copy link
Member

For many years now we haven't supported Modal for Windows. This is largely due to the fact that the Modal component itself doesn't do much of the heavy lifting people come to expect from this type of UI on desktop (where there are more demands than on the constrained screen of mobile). To help address those we do have 2 Windows-only components that provide more desktop and UWP/XAML-centric behavior: Flyout and Popup

On the Paper renderer, we're not going to implement Modal. We're investing our time in closing the gap on the Fabric renderer, where this question is going to be revisited anew. The work to track Modal on Fabric is here. As such, I'm going to close this issue as Not Planned and we'll look to the Fabric issue moving forward.

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: Completion enhancement Partner: 3P 3rd party customer asks Recommend: Not Planned Recommend that issue should be given Not Planned milestone. Story: ⚖ Parity Be a 1st class RN platform (which means supporting most of its APIs)
Projects
None yet
Development

No branches or pull requests