Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the WindowsAppSDK app template and projects #11744

Closed
6 tasks
Tracked by #11920
jonthysell opened this issue Jun 12, 2023 · 1 comment · Fixed by #11945
Closed
6 tasks
Tracked by #11920

Deprecate the WindowsAppSDK app template and projects #11744

jonthysell opened this issue Jun 12, 2023 · 1 comment · Fixed by #11945

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Jun 12, 2023

Summary

As we work on the plan-of-record Fabric implementation based on Composition, we no longer need the experimental projects based on the Windows App SDK.

Specifically, we need to:

  • Remove the existing WindowsAppSDK code from react-native-windows:
    • ./vnext/Microsoft.ReactNative.WindowsAppSDK.sln solution
    • ./vnext/Microsoft.ReactNative.WindowsAppSDK/ directory and projects
    • ./vnext/template/cs-app-WinAppSDK/ template
    • ./vnext/PropertySheets/External/Microsoft.ReactNative.WinAppSDK.*.* property sheets
    • ./vnext/Scripts/Microsoft.ReactNative.WindowsAppSDK.nuspec nuget config file
  • Remove new project code from @react-native-windows/cli
  • Remove WinUI3 permutations (i.e. RnwNativeBuildWinAppSDK job) from ./ado/publish.yml
  • Remove WinUI3 permutations from matrix in ./ado/jobs/cli-init.yml
  • Remove ./ado/jobs/windowsappsdk.yml
  • Remove WinAppSDK permutations from ./ado/stages.yml

Motivation

These projects/templates were early, experimental work for a future of RNW apps being WinAppSDK-based. Since we're not going in that direction, we shouldn't persist allowing projects to be created using it.

Basic Example

No response

Open Questions

  • What happens if we leave the UseWinUI3 flag in our other projects? Without a published binary, is that flag even useful anymore?
    • Maybe for "unsupported" UWP+WinUI3 apps?
    • Maybe for unpackaged win32 apps like playground-win32?
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 12, 2023
@jonthysell
Copy link
Contributor Author

Possibly related to #8133?

@chrisglein chrisglein added Area: Infrastructure Platform: WinAppSDK and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jun 15, 2023
@chrisglein chrisglein added this to the Backlog milestone Jun 15, 2023
jonthysell added a commit that referenced this issue Aug 7, 2023
## Description

This PR deprecates the `Microsoft.ReactNative.WindowsAppSDK` project.

### Type of Change
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

### Why

These projects/templates were early, experimental work for a future of RNW apps being WinAppSDK-based. Since we're not going in that direction, we shouldn't persist allowing projects to be created using it.

Resolves #11744

### What

* Deleting the `Microsoft.ReactNative.WindowsAppSDK` project files
* Removing all jobs/tasks related to building/testing/publishing `Microsoft.ReactNative.WindowsAppSDK`
* Removes the `cs-app-WinAppSDK` app template and specific new project creation code

**Note:** The existing `UseWinUI3` msbuild property and corresponding `USE_WINUI3` build flags are intentionally not touched in this PR, to maintain the minimum support for some customers.

## Screenshots
N/A

## Testing
N/A

## Changelog
Should this change be included in the release notes: Yes

The Microsoft.ReactNative.WindowsAppSDK experimental project has been deprecated and will no longer be supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants