Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] run-windows Script Should Work By Default on Fabric #12026

Closed
chiaramooney opened this issue Aug 16, 2023 · 2 comments
Closed

[Fabric] run-windows Script Should Work By Default on Fabric #12026

chiaramooney opened this issue Aug 16, 2023 · 2 comments
Labels
Area: CLI Area: Fabric Support Facebook Fabric bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Backlog

Comments

@chiaramooney
Copy link
Contributor

Currently when you try to build a Fabric app using the CLI the script will fail with an error message that the app cannot be deployed. This makes sense because Win32 apps do not bundle and are not deployed. We should make a design decision here if Fabric apps should have to explicitly specify --no-deploy in order for run-windows to succeed, or should the script be adjusted to detect if the app is on the old or new architecture and adjust its behavior accordingly. There are other behavior options here; these are just some examples.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 16, 2023
@chiaramooney chiaramooney added Area: Fabric Support Facebook Fabric Area: CLI Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 16, 2023
@chrisglein
Copy link
Member

For Fabric apps they're going to be plain old EXEs that need to be run, not deployed.
As we decide what is the golden path for the default Fabric app (packaged/unpackaged, Win32/UWP, C++/C#), the CLI should work.

Related #11564.

@chrisglein chrisglein added bug and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 17, 2023
@chrisglein chrisglein added this to the Backlog milestone Aug 17, 2023
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
@chrisglein
Copy link
Member

This works now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: CLI Area: Fabric Support Facebook Fabric bug New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jonthysell @chrisglein @chiaramooney