Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release builds of Fabric should bundle #11564

Closed
chrisglein opened this issue May 5, 2023 · 3 comments
Closed

Release builds of Fabric should bundle #11564

chrisglein opened this issue May 5, 2023 · 3 comments
Assignees
@chrisglein
Labels
Area: Build Infrastructure Area: Bundle Area: Fabric Support Facebook Fabric enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Next

Comments

@chrisglein
Copy link
Member

Related to this: #8116

I'm no expert on non-UWP packaged apps, but there's definitely intersection here as to where the bundle goes. One option is to embed it as a classic Win32 embedded resource, which we support (resource:// according to the docs).

The resource would need to be populated by part of the build process, which has been explored before here to create a generated RC file that is then imported here.
@chrisglein chrisglein added this to the Backlog milestone May 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 5, 2023
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 8, 2023
@chrisglein
Copy link
Member Author

Next step: replicate the steps applied to the Win32 console app to embed the resource and see if that can be applied to the eventual template app.

@chrisglein chrisglein self-assigned this May 8, 2023
This was referenced Jun 14, 2023
Open
Open
@chrisglein chrisglein mentioned this issue Aug 17, 2023
Closed
@YajurG YajurG added the Recommend: Backlog Recommend that issue should be given Backlog milestone. label Aug 31, 2023
@chiaramooney chiaramooney removed the Recommend: Backlog Recommend that issue should be given Backlog milestone. label Sep 19, 2023
@chrisglein
Copy link
Member Author

This has been implemented. But when running as a fully published store app it fails with this error:
[0x80070057] The specified path (UNABLE_TO_MASK_PATH) is too long. It exceeds the maximum length of -202377800.

@chrisglein chrisglein modified the milestones: Backlog, Next Nov 7, 2023
@chrisglein
Copy link
Member Author

Verified working as of canary 776 in this PR: chrisglein/artificial-chat#137

@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisglein chrisglein

Labels
Area: Build Infrastructure Area: Bundle Area: Fabric Support Facebook Fabric enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
Next
Development

No branches or pull requests
4 participants
@jonthysell @chrisglein @YajurG @chiaramooney