Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable loading the bundle from an embedded resource #9769

Closed
asklar opened this issue Apr 2, 2022 · 0 comments · Fixed by #9768
Closed

Enable loading the bundle from an embedded resource #9769

asklar opened this issue Apr 2, 2022 · 0 comments · Fixed by #9768
Assignees
Milestone

Comments

@asklar
Copy link
Member

asklar commented Apr 2, 2022

We should enable embedded resources as a mechanism to carry the JS bundle with the app; this will be relevant in the win32/WinAppSDK world if we decide to / for customers that don't want to deal with MRT/MRTCore.

One way to do this is to reuse the existing BundleRootPath, which currently accepts file paths as well as URIs. For appx, we accept ms-appx etc. We could start accepting something like resource:// as a uri scheme.

The desktop DLL used by Office already has code for reading from an embedded resource; once we add this functionality to the official library, we can work with Office to move to the standard API.

This will accrue towards #8116

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 2, 2022
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Apr 4, 2022
@chrisglein chrisglein added this to the 0.69 milestone Apr 4, 2022
@ghost ghost closed this as completed in #9768 Apr 6, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants