Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a "new-lib" template, defaulting to C++, Fabric, Hermes, NuGet-based, Win32 lib #12480

Closed
Tracked by #11920
jonthysell opened this issue Dec 1, 2023 · 0 comments · Fixed by #12481
Closed
Tracked by #11920

Create a "new-lib" template, defaulting to C++, Fabric, Hermes, NuGet-based, Win32 lib #12480

jonthysell opened this issue Dec 1, 2023 · 0 comments · Fixed by #12481
Assignees
@jonthysell
Labels
Area: Fabric Support Facebook Fabric Area: Native Modules New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
0.74

Comments

@jonthysell
Copy link
Contributor

No description provided.

@jonthysell jonthysell mentioned this issue Dec 1, 2023
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 1, 2023
@jonthysell jonthysell mentioned this issue Dec 1, 2023
Merged
@jonthysell jonthysell self-assigned this Dec 4, 2023
@jonthysell jonthysell added Area: Native Modules and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 4, 2023
@jonthysell jonthysell added this to the 0.74 milestone Dec 4, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Dec 5, 2023
@jonthysell jonthysell added Area: Fabric Support Facebook Fabric and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Dec 5, 2023
jonthysell added a commit to jonthysell/react-native-windows that referenced this issue Dec 5, 2023
@jonthysell
Create new arch module template: cpp-lib
edc3a07 
## Description

Adds a new `cpp-lib` template designed to be applied on top of the new projects created by the (now recommended) `create-react-native-library` script.

### Type of Change
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update

### Why
Devs need to add windows support to native modules in a way which can be consumed by the new arch RNW apps (i.e. the `cpp-app` template).

Resolves microsoft#12480

### What
Create a new `cpp-lib` template which can be applied on top of the template created by `npx  create-react-native-library`, adding Windows support for a turbo module. It will also automatically apply the `cpp-app` template to the example project if it exists.

## Screenshots
<img width="441" alt="image" src="https://github.com/microsoft/react-native-windows/assets/10852185/f5f31727-a233-419c-8afe-ad91f797abb2">

## Testing
Verified the new template could be applied to a fresh library created by `create-react-native-library` and that example app autolinks, builds, and runs correctly.

## Changelog
Should this change be included in the release notes: yes

Created a new arch module template: cpp-lib
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Dec 6, 2023
jonthysell added a commit that referenced this issue Jan 18, 2024
@jonthysell
Create new arch module template: cpp-lib (#12481)
6164875 
## Description

Adds a new `cpp-lib` template designed to be applied on top of the new projects created by the (now recommended) `create-react-native-library` script. Also updates the `cpp-app` template to be able to autolink and run these new libraries.

### Type of Change
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update

### Why
Devs need to add windows support to native modules in a way which can be consumed by the new arch RNW apps (i.e. the `cpp-app` template).

Resolves #12480

### What
Create a new `cpp-lib` template which can be applied on top of the template created by `npx  create-react-native-library`, adding Windows support for a turbo module. It will also automatically apply the `cpp-app` template to the example project if it exists.

## Screenshots
<img width="441" alt="image" src="https://github.com/microsoft/react-native-windows/assets/10852185/f5f31727-a233-419c-8afe-ad91f797abb2">


## Testing
Verified the new template could be applied to a fresh library created by `create-react-native-library` and that example app autolinks, builds, and runs correctly.

## Changelog
Should this change be included in the release notes: yes

Created a new arch module template: cpp-lib
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
@jonthysell jonthysell removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonthysell jonthysell

Labels
Area: Fabric Support Facebook Fabric Area: Native Modules New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
0.74
Development

Successfully merging a pull request may close this issue.

Create new arch module template: cpp-lib jonthysell/react-native-windows
1 participant
@jonthysell