Skip to content

Update PR with feedback from design review #15117

@anupriya13

Description

@anupriya13

Update this PR #15093 with following feedback:
create a branch from this PR branch user/anuverma/cli_CM and fix below:

  • rename to setup-module-windows
  • instead of removing multiply function keep it with a comment to take it as a reference only: Consider adding some kind of Hello, world as a replacement for the old multiply. It’s there for a newbie module author to know that things worked when they deploy a module. For instance, the first react app screen shows something meaningful when things work.
  • Check if TurboModule Spec exists, if not return with error "Create Spec File" to user and end. Dont' try to create a new sepc if doesnt exists

Metadata

Metadata

Assignees

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions