Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to switch SampleApps.sln build platform in Visual Studio #9424

Closed
jonthysell opened this issue Jan 24, 2022 · 5 comments · Fixed by #9442
Closed

Unable to switch SampleApps.sln build platform in Visual Studio #9424

jonthysell opened this issue Jan 24, 2022 · 5 comments · Fixed by #9442
Assignees
Labels
Milestone

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Jan 24, 2022

Problem Description

I'm trying to build SampleApps.sln, Debug x86, from main, in any VS supported version. By default when I open the solution, Debug ARM64 is chosen.

If I switch to x86, VS hangs forever:

image

This does not repro with 0.67-stable. I believe this may be some kind of race condition with VS trying to restore the nuget packages because of the new PackageReference stuff.

Steps To Reproduce

  1. Clone, yarn install, yarn build repo
  2. Open SampleApps.sln in VS 2019 or 2022
  3. Change build platform to x86

Expected Results

Solution changes platform so I can build it

CLI version

npx react-native --version

Environment

npx react-native info

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

2019, 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

No response

@jonthysell jonthysell added the bug label Jan 24, 2022
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 24, 2022
@asklar asklar added this to the 0.68 milestone Jan 24, 2022
@asklar
Copy link
Member

asklar commented Jan 24, 2022

@JunielKatarn Jon thinks this might be due to the PackageReference change, could you take a look?

@asklar asklar removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 24, 2022
@JunielKatarn
Copy link
Contributor

I'll take a look today. Verifying this should be simple.

@JunielKatarn
Copy link
Contributor

JunielKatarn commented Jan 25, 2022

I have successfully reproduced the issue on the latest main commit as of today (6dd9d8183c3dcf582684ae136a6fb771a213ed80).

Environment:

  • npx 8.2.0
  • Visual Studio 2019

However, this may not be inherent to the PackageReference feature.

  • Commit 522f0c8f1eec1a4e52ea4105685b99a5f3ea96d9: No repro
    Last commit before introducing PacageReference for C++ projects.
  • Commit bcdf9ad68eeda2967062f5137bc0f248e2ce7897: No repro either
    Commit introducing the PackageReference for C++ feature.

I'll do a binary search to find the first commit that hits the issue consistently.

@JunielKatarn
Copy link
Contributor

Bug confirmed also in Visual Studio 2022.

@JunielKatarn JunielKatarn changed the title Unable to switch SampleApps.sln build platform in VS2019 Unable to switch SampleApps.sln build platform in Visual Studio Jan 25, 2022
@JunielKatarn
Copy link
Contributor

JunielKatarn commented Jan 26, 2022

Bug introduced by commit ff37d64c0d44623d9884e5df7f0f027e4371d53c (#9401).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants