Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VS hang when switching Platform within IDE #9442

Merged
merged 7 commits into from
Feb 2, 2022
Merged

Fix VS hang when switching Platform within IDE #9442

merged 7 commits into from
Feb 2, 2022

Conversation

JunielKatarn
Copy link
Contributor

@JunielKatarn JunielKatarn commented Jan 29, 2022 •
edited
Loading

Description

Restore ability to switch platforms within Visual Studio.
Fix dependency restoration from within Visual Studio.

Type of Change

  • Bug fix

Follow up on #8195.

Why

There are developer experience regressions introduced by usage of PackageReference C++ dependencies when building exclusively with the Visual Studio IDE.

Resolves #9424
Resolves #9436

What

  • Implicitly restore VCXPROJ when using Visual Studio
  • Don't use RestoreUseStaticGraphEvaluation when dealing with packages.config

Testing

Sample Apps

Using a clean clone and a completely empty user NuGet cache (globalPackagesFolder):

  • Run yarn; yarn build.
  • Open solution packages\sample-apps\windows\SampleApps.sln.
  • Wait for solution to load.
  • Switch the platform to x86.
  • Build solution.

Playground

Using a clean clone and a completely empty user NuGet cache (globalPackagesFolder):

  • Run yarn; yarn build.
  • Open solution packages\playground\windows\playground.sln.
  • Wait for solution to load.
  • Build solution.
  • Switch the platform to x86.
  • Build solution.
Microsoft Reviewers: Open in CodeFlow

@JunielKatarn JunielKatarn requested review from a team as code owners January 29, 2022 08:12
@JunielKatarn JunielKatarn requested review from a team and removed request for a team January 31, 2022 04:49
@ghost ghost added the Area: Playground label Jan 31, 2022
@jonthysell
Copy link
Contributor

This looks like it fixed the SampleApps, but switching the Platform in playground now hangs. I'll check my setup again.

@JunielKatarn
Copy link
Contributor Author

This looks like it fixed the SampleApps, but switching the Platform in playground now hangs. I'll check my setup again.

I just checked switching and building Playground on a fresh clone (using this branch).
It works without issues.

NikoAri
NikoAri approved these changes Feb 1, 2022
View reviewed changes
Copy link

@NikoAri NikoAri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jonthysell
jonthysell approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@jonthysell jonthysell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got playground to build.

@JunielKatarn JunielKatarn merged commit 6b01666 into microsoft:main Feb 2, 2022
@JunielKatarn JunielKatarn deleted the issues/9424/vshang branch February 2, 2022 01:43
@JunielKatarn JunielKatarn added the PackageReference Modern NuGet restore used in C++ projects label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikoAri NikoAri NikoAri approved these changes

@jonthysell jonthysell jonthysell approved these changes

Assignees
No one assigned
Labels
Area: Build Infrastructure Area: Playground PackageReference Modern NuGet restore used in C++ projects
Projects
None yet
Milestone
No milestone
3 participants
@JunielKatarn @jonthysell @NikoAri