Enable ability to codegen JSI C++ TurboModule specs #10909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our codegen currently generates spec files for modules using REACT_MODULE. There exists a whole other set of codegen for generating c++ JSI modules. We already support c++ JSI modules. This change enables users of the codegen project to opt in to generate the c++ JSI specs if desired.
Testing
We have an integration test that uses a copy/pasted older version of the generated c++ JSI module code, and uses that to run a c++ JSI turbomodule. This replaces that code with code that is generated at build time, so that the test case will keep up with currently generated code.
Microsoft Reviewers: Open in CodeFlow