-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FlatList Visual Snapshot Tests to E2E Tests Fabric #12870
Draft
chiaramooney
wants to merge
15
commits into
microsoft:main
Choose a base branch
from
chiaramooney:cm-flatlist-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonthysell
added
Area: FlatList
Area: Fabric
Support Facebook Fabric
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
labels
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Fabric
Support Facebook Fabric
Area: FlatList
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Increase automated validation of RNW Fabric.
#11277
What
Add Visual Snapshot tests for FlatList control. Needed to fork some of the RN Testers example pages for FlatList in order to add testIDs to the example. We upstream the testID additions so we can defork later. See #12869.
Changelog
Should this change be included in the release notes: No
Microsoft Reviewers: Open in CodeFlow