Cleans up LongLivedObjectCollection created by RN Windows #12934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native now intrinsically supports per-VM LongLivedObjectCollections, so the additional behavior in Windows is redundant.
rozele
force-pushed
the
longLivedObjectCleanup
branch
from
f56e136
to
90f88e1
Compare
|
@vmoroz Can you review this, since you were dealing with something similar a short time ago? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
Our app has some cross platform JSI modules that use the default
LongLivedObjectCollection, which does not get cleaned up by react-native-windows. Moving to the intrinsically per-VMLongLivedObjectCollectionhelps :).Resolves [Add Relevant Issue Here]
What
Eliminates the LongLivedObjectCollection created by TurboModulesProvider.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow