Add warnings and deprecations for react-native-windows-init #13488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && parsedVersion.prerelease.length > 1 | ||
| && parsedVersion.prerelease[0] === 'canary' | ||
| && typeof parsedVersion.prerelease[1] === 'number' | ||
| && parsedVersion.prerelease[1] > 843) |
There was a problem hiding this comment.
just curious what is "parsedVersion.prerelease[1] > 843" checking?
There was a problem hiding this comment.
I want to throw the error for > 0.0.0-canary.843. I still want the command to work for older canary builds (not sure if it really matters).
TatianaKapos
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds version checking to
react-native-windows-initto give a deprecation warning if the user tries to use it for RNW 0.75 and an error if they use it on a newer version.Type of Change
Why
We will be deprecating
react-native-windows-initin favor of newer methods for adding RNW projects.Resolves #13461
What
See above.
Screenshots
N/A
Testing
Verified I could se the warning/error when using it with
Changelog
Should this change be included in the release notes: yes
Add warnings and deprecations for react-native-windows-init
Microsoft Reviewers: Open in CodeFlow