Fix Alerts and Flyouts crashing on Windows 10 1809 (RS5) #13505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Vendora" |
acoates-ms
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Opening Alerts and Flyouts crashes on Windows 10 1809
Resolves #13502
What
Adds more version checks around uses of XamlRoot, which was added in the next version 19H1. There were a few uses of
is19H1OrHigher, but not all XamlRoot related code was wrapped.Changelog
Should this change be included in the release notes: yes
Fix alerts and flyouts crashing on Windows 10 1809
Microsoft Reviewers: Open in CodeFlow