Update creaternw scripts to use RNW devDependencies #14491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
added
the
Workstream: Developer Experience
TatianaKapos
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
creaternwapp.cmdand creaternwlib.cmd scripts have an issue where new RN projects won't use the range qualifier in peerDependencies (so you ask forreact-native@^0.74.0and you getreact-native@0.74.0even thoughreact-native@0.74.5exists).This PR fixes the script to, when determining which
reactandreact-nativeversion to use, to look atreact-native-windows's devDependency, which is more reliable than the peerDependency.Type of Change
Why
Unexpectedly having the wrong RN project version causes all sorts of build issues and confusion, and is easy to miss.
What
See above.
Screenshots
N/A
Testing
Verfied it works for new projects.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow