Skip to content

Textinput double clicking selects text #14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 6 commits into from
Apr 12, 2025
Merged

Textinput double clicking selects text #14515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7814c35
added check for double click on textInput component view connecting …
Apr 11, 2025
f067871
Change files
Apr 11, 2025
43fd9cb
Merge branch 'main' into doubleclickselect
iamAbhi-916 Apr 11, 2025
6b67779
updated for lint fix
Apr 11, 2025
7f951e2
Merge branch 'doubleclickselect' of https://github.com/iamAbhi-916/re…
Apr 11, 2025
789f036
updated to remove position( Distance check)
Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-537a723b-a3c7-48fe-aec0-c53ca7d201e3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "added check for double click on textInput component view connecting it to WM_LBUTTONDBLCLK",
"packageName": "react-native-windows",
"email": "email not defined",
"dependentChangeType": "none"
}
19 changes: 18 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,19 @@ WPARAM PointerRoutedEventArgsToMouseWParam(
return wParam;
}

bool WindowsTextInputComponentView::IsDoubleClick() {
using namespace std::chrono;

auto now = steady_clock::now();
auto duration = duration_cast<milliseconds>(now - m_lastClickTime).count();

const int DOUBLE_CLICK_TIME_MS = ::GetDoubleClickTime();

m_lastClickTime = now;

return (duration < DOUBLE_CLICK_TIME_MS);
}

void WindowsTextInputComponentView::OnPointerPressed(
const winrt::Microsoft::ReactNative::Composition::Input::PointerRoutedEventArgs &args) noexcept {
UINT msg = 0;
Expand All @@ -637,7 +650,11 @@ void WindowsTextInputComponentView::OnPointerPressed(
if (pp.PointerDeviceType() == winrt::Microsoft::ReactNative::Composition::Input::PointerDeviceType::Mouse) {
switch (pp.Properties().PointerUpdateKind()) {
case winrt::Microsoft::ReactNative::Composition::Input::PointerUpdateKind::LeftButtonPressed:
msg = WM_LBUTTONDOWN;
if (IsDoubleClick()) {
msg = WM_LBUTTONDBLCLK;
} else {
msg = WM_LBUTTONDOWN;
}
break;
case winrt::Microsoft::ReactNative::Composition::Input::PointerUpdateKind::MiddleButtonPressed:
msg = WM_MBUTTONDOWN;
Expand Down
2 changes: 2 additions & 0 deletions vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ struct WindowsTextInputComponentView
std::optional<std::string> getAccessiblityValue() noexcept override;
void setAcccessiblityValue(std::string &&value) noexcept override;
bool getAcccessiblityIsReadOnly() noexcept override;
bool IsDoubleClick();

WindowsTextInputComponentView(
const winrt::Microsoft::ReactNative::Composition::Experimental::ICompositionContext &compContext,
Expand Down Expand Up @@ -140,6 +141,7 @@ struct WindowsTextInputComponentView
DWORD m_propBitsMask{0};
DWORD m_propBits{0};
HCURSOR m_hcursor{nullptr};
std::chrono::steady_clock::time_point m_lastClickTime{};
std::vector<facebook::react::CompWindowsTextInputSubmitKeyEventsStruct> m_submitKeyEvents;
};

Expand Down
Loading