Skip to content

Add support for aria-hidden/accessibilityElementsHidden prop. #14560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Add support for aria-hidden/accessibilityElementsHidden prop. #14560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bbe8b68
Implement the onContentSizeChange property for the fabric implementat…
satkh Apr 3, 2025
58ce921
Revert "Implement the onContentSizeChange property for the fabric imp…
satkh Apr 3, 2025
0a4efcf
Merge branch 'main' of https://github.com/microsoft/react-native-windows
satkh Apr 3, 2025
587b53f
Merge branch 'main' of https://github.com/microsoft/react-native-windows
satkh Apr 8, 2025
17b1173
Merge branch 'main' of https://github.com/microsoft/react-native-windows
satkh Apr 16, 2025
0cb49f3
Draft Implemenation
satkh Apr 17, 2025
af72eaf
Lint errors
satkh Apr 17, 2025
6d55603
Change files
satkh Apr 17, 2025
bae9f9b
Merge branch 'main' into user/satkh/accessibilityElementsHidden_prop_1
satkh Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-b12cdfc7-1f09-4dfd-912a-551ec96fd65b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Draft Implemenation",
"packageName": "react-native-windows",
"email": "satkh@microsoft.com",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions packages/playground/Samples/accessible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ export default class Bootstrap extends React.Component<
<Text style={styles.text}>TEST setAccessibilityFocus</Text>
</TouchableHighlight>
<TextInput ref={this.myElement} />
<View style={styles.item} accessibilityElementsHidden={true}>
<Text style={styles.text}>TEST Accessibility Hidden </Text>
</View>
</View>
);
}
Expand Down
1 change: 1 addition & 0 deletions vnext/src-win/Libraries/Components/View/ReactNativeViewAttributes.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const UIView = {
accessibilityShowsLargeContentViewer: true,
accessibilityLargeContentTitle: true,
importantForAccessibility: true,
accessibilityElementsHidden: false,
nativeID: true,
testID: true,
renderToHardwareTextureAndroid: true,
Expand Down
6 changes: 4 additions & 2 deletions vnext/src-win/Libraries/Components/View/View.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ const View: component(
// [Windows
accessible={_accessible}
children={
importantForAccessibility === 'no-hide-descendants'
importantForAccessibility === 'no-hide-descendants' ||
accessibilityElementsHidden === true
? childrenWithImportantForAccessibility(otherProps.children)
: otherProps.children
}
Expand Down Expand Up @@ -327,7 +328,8 @@ const View: component(
// [Windows
accessible={_accessible}
children={
importantForAccessibility === 'no-hide-descendants'
importantForAccessibility === 'no-hide-descendants' ||
accessibilityElementsHidden === true
? childrenWithImportantForAccessibility(otherProps.children)
: otherProps.children
}
Expand Down