Skip to content

[0.76] Cherry pick a bunch of fabric fixes, and update WASDK to release version #14606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 24, 2025

Conversation

acoates-ms
Copy link
Contributor

@acoates-ms acoates-ms commented Apr 22, 2025

Microsoft Reviewers: Open in CodeFlow

chiaramooney and others added 23 commits April 22, 2025 15:59
* Save State

* Continue ScrollProvider Implementation

* Complete Implementation

* Add Test Infra

* Change files

* Format + Remove Unneeded

* Add Override

* Update Snapshots

* Add Comments
* Introduce support for textAlign

* Add playground textinputs demonstrating textAlign

* Oops, let's remove textAlignOnUpdateProps

* Change files

* Lint fixes

* Nit

* Make textAlign to be of facebook::react::TextAlignment type

* Lint fixes

* Don't reinvent the wheel :D

* Nit: yarn format
…14444)

* Button should pass onAccessibilityTap to native

* Change files
* get images/views inline with text on fabric

* add back in comments

* Change files

* remove duplicate code

* add baseline for textinput

* add checks for paper vs fabric

* try fixing image

* add resize:none and tests

* fix override

* comment out test

* fix tests

* fix typo

* try to fix tests

* comment out text test

* mark windows-specific changes
* Allow TextInput to scroll

* Change files

* update snapshot
…osoft#14446)

 Implement onScrollBeginDrag property for ScrollView for fabric (microsoft#14446)
* Implement letterSpacing for TextInput

* Change files

* Update react-native-windows-9ee8d633-698c-476d-9334-170be2c5dc25.json

* Update textinput.tsx

* optimize code
* Added tooltip property in Text.windows.js TextProps.windows.js for typescript to recognise it as an attribute of Text component

* Added override Text.d.ts to src-win/Libraries/Text/ to add  tooltip prop to Text component

* Change files

* Added Sample/text for tooltip prop tests

* Added TextPropsWindows to include windows specific prop tooltip

* updated TextProps interface to extednd TextPropsWindows

* lint fix for Sample/text.tsx file

---------

Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com>
* Fix Narrator Bug

* Change files

* Revert Codegen Changes
* implemented on onEndEditing

* Change files

* Update textinput.tsx to remove keyboard=dismiss which actually will cause blur or lost focus implicitly

* lint fixes

* updated legacy textInput snapshot for component update

---------

Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com>
* added check for double click on textInput component view connecting it to WM_LBUTTONDBLCLK

* Change files

* updated for lint fix

* updated to remove position( Distance check)

---------

Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com>
* Add SetAppProperties method to ReactNativeIsland

* Change files

* rename SetAppProperties to SetProperties

* change file

* fix

* fix
…soft#14568)

* Implement body in Image Source

* Change files

* Add test in playground
…n ScrollView (microsoft#14562)

* Implemet maximumZoomScale and minimumZoomScalein ScrollView

* Change files

* lint fix

* Add zoomScale
…#14519)

* Implementation of adjustFontSizeToFit

* Final Changes using TextLayout

* Lint Issue Fixes

* Change files

* prop change detection added

* review Changes and E2E test cases added

* Lint and Format Changes added

* Test Cases Fix added

* Update SnapShot

* Removed the additional Check for resizing Font

* Updated SnapShot

* Review Changes

* Lint and Format Changes

---------

Co-authored-by: Vineeth K <kvineeth@microsoft.com>
@acoates-ms acoates-ms changed the base branch from main to 0.76-stable April 22, 2025 23:54
@acoates-ms acoates-ms marked this pull request as ready for review April 24, 2025 16:59
@acoates-ms acoates-ms requested review from a team as code owners April 24, 2025 16:59
@acoates-ms acoates-ms changed the title [0.76] cherry picks [0.76] Cherry pick a bunch of fabric fixes, and update WASDK to release version Apr 24, 2025
@acoates-ms
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

Copy link
Contributor

@TatianaKapos TatianaKapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acoates-ms acoates-ms merged commit e9875d8 into microsoft:0.76-stable Apr 24, 2025
101 checks passed
@acoates-ms acoates-ms deleted the cherrypickwasdk76 branch April 24, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants