Skip to content

Fix : Incorrect view access to obtain ContentIsland from for the DesktopPopupSiteBridge #14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamAbhi-916 merged 16 commits into from
May 2, 2025
Merged

Fix : Incorrect view access to obtain ContentIsland from for the DesktopPopupSiteBridge #14628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
510c188
solved access read violation due to incorrect view access to obtain …
Apr 29, 2025
5f22a8d
rolling back text.tsx
Apr 29, 2025
b80a94d
Update end of line text.tsx
iamAbhi-916 Apr 29, 2025
05d519a
rolled back Playground-Composition.vcxproj
iamAbhi-916 Apr 29, 2025
a23f40c
rolled back Playground-Composition.vcxproj
iamAbhi-916 Apr 29, 2025
577a0ff
fixed lint Playground-Composition.vcxproj
iamAbhi-916 Apr 29, 2025
3645907
master Playground-Composition.vcxproj
iamAbhi-916 Apr 29, 2025
00dd72f
rolled back Playground-Composition.vcxproj
iamAbhi-916 Apr 29, 2025
67e268a
Merge branch 'main' into modal-title
iamAbhi-916 Apr 30, 2025
b31f93b
indentation fix Playground-Composition.vcxproj
iamAbhi-916 Apr 30, 2025
ea9a45c
Revert unintended changes in Playground-Composition.vcxproj
Apr 30, 2025
1c2c193
added patch for winUiex[erimental removal
Apr 30, 2025
4de470d
Merge branch 'main' into modal-title
iamAbhi-916 Apr 30, 2025
809a39b
Change files
Apr 30, 2025
a9a6ab6
Merge branch 'modal-title' of https://github.com/iamAbhi-916/react-na…
Apr 30, 2025
1f4ac7e
Merge branch 'main' into modal-title
vineethkuttan May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-7f8685f6-e3f8-4d09-8b36-e11de0eecd62.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "solved access read violation due to incorrect view access to obtain contentIsland",
"packageName": "react-native-windows",
"email": "abhijeetjha@microsoft.com",
"dependentChangeType": "none"
}
1 change: 0 additions & 1 deletion vnext/Microsoft.ReactNative/Fabric/Composition/Modal/WindowsModalHostViewComponentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ struct ModalHostView : public winrt::implements<ModalHostView, winrt::Windows::F

m_popUp = winrt::Microsoft::UI::Content::DesktopPopupSiteBridge::Create(
portal.Parent()
.Parent()
.as<winrt::Microsoft::ReactNative::Composition::ComponentView>()
.Root()
.ReactNativeIsland()
Expand Down
Loading