[Fabric] Raising UIA Event if Toggle State Changes in Switch Component #15023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Introduced m_localToggleState cause , when clicking switch, narrator calls IToogleState function to get the toggle state , at that causes it to announce wrong state , that is it will announce Off for On and On for Off |
chiaramooney
approved these changes
Aug 7, 2025
Contributor
chiaramooney
left a comment
chiaramooney
left a comment
There was a problem hiding this comment.
This seems fine to me; just verify that all the switch tests pass before merging. Also maybe try out some edge cases to make sure there aren't any unintended changes to the switch controls logic
acoates-ms
reviewed
Aug 7, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/SwitchComponentView.h
Outdated
Show resolved
Hide resolved
acoates-ms
reviewed
Aug 7, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/SwitchComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
reviewed
Aug 7, 2025
vnext/Microsoft.ReactNative/Fabric/Composition/SwitchComponentView.cpp
Outdated
Show resolved
Hide resolved
acoates-ms
approved these changes
Aug 7, 2025
vineethkuttan
added a commit
that referenced
this pull request
Sep 2, 2025
#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0
vineethkuttan
added a commit
that referenced
this pull request
Sep 2, 2025
…#15105) * [Fabric] Implement announceForAccessibility in AccessibilityInfo Module (#14995) * Implementation of announce for accessibility for fabric * Build fix * Removed Debug Message * Yarn Change * Copilot Suggestions * Review Changes * Storing the weak_ref island in property to avoid circular ref * Adding deleted Change Files * [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0 * [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Sep 11, 2025
microsoft#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0
acoates-ms
added a commit
that referenced
this pull request
Sep 19, 2025
* Pointer events (#14713) * PointerEvent fixes * Change files * format * [Fabric] Implement SpellCheck and AutoCorrect for TextInput (#14509) * Fabric : Added support for selectionColor in TextInput component (#14743) * Added support for selectionColor for textInput * yarn fix and format * Change files * Implement adjustsFontSizeToFit property for Text in Fabric (#14519) * Implementation of adjustFontSizeToFit * Final Changes using TextLayout * Lint Issue Fixes * Change files * prop change detection added * review Changes and E2E test cases added * Lint and Format Changes added * Test Cases Fix added * Update SnapShot * Removed the additional Check for resizing Font * Updated SnapShot * Review Changes * Lint and Format Changes --------- Co-authored-by: Vineeth K <kvineeth@microsoft.com> * Text : Added EllipsizeMode for tail and clip alignment (#14660) * updated ellipsis to respect tail and clip behaviour , for head , middle follow defaulty tail behaviour * patched updateTextAlignment method * Change files * pathced branch , lint fix , lint format * updated snapshots * added layout changes to TextLayoutManager * lint fix and format * updated snapshots * updated snapshot Pressable component * updated to remove extra text_layout null check * removed comments * format and lint:fix * [Fabric] Implement onContentSizeChange in TextInput (#14785) * Fix : adjustsFontSizeToFit just redrawing won't recalculate the layout (#14813) * updated adjustsFontSizeToFit textlayout to nullptr * Change files * [Fabric] Implement autoFocus property for TextInput for fabric (#14816) * Added fix for AutoFocus * Change files --------- Co-authored-by: Harini Malothu <hmalothu@microsoft.com> * [Fabric] Implementation of accessibilityDescription (#14818) * Initial Commit for accessibilityDescription * Change files * Format Changes * Updating Snapshot * [Fabric] Implement maxFontSizeMultiplier in Text Input (#14639) * [Fabric] Fix for updating accessibility value in UIA (#14858) * Changes for updating accessibilityValue prop * Change files * TextInput should capture mouse on mouse down (#14983) * TextInput should capture mouse on mouse down * Change files * format * [Fabric] Raising UIA Event if Toggle State Changes in Switch Component (#15023) * Update Toggle State to Narrator * Yarn Change * Review Changes * Review Changes 2.0 * [Fabric] Add Support for ITextProvider, ITextProvider2, and ITextRangeProvider (#14332) * Partial Implementation * Add More Implementation * More Implementation * More Implementation * Add Support for Bounding Rectangles * Complete Initial Implementation * Change files * Code Cleanup * Code Cleanup * Update Snapshots + Code Cleanup * Update Snapshots * Address Feedback * Address Feedback * Update Snapshots * Fix Tests --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com> * [Fabric] Fix for Text and TextInput focus issue with screen readers (#15088) * Few more implementation of TextRange Provider * Yarn change * Update Change file * Screen reader fails to announce the expand/collapse state of the navigation button (#15106) * adding UIA event handler changes for navigator * Change files * adding ViewComponent chnages for accessibility * removing unnecessary change file * Remove vnext/fmt/packages.lock.json --------- Co-authored-by: Protik Biswas <protikbiswas100@microsoft.com> * fix * fix * Upgrade dotnet version * Change files * bump sdk * bump node * fix * fix * Change files * fix * fix * test * fix * fix * update snapshots * snapshot * snapshot * measureLines * fix * snapshot --------- Co-authored-by: Anupriya Verma <54227869+anupriya13@users.noreply.github.com> Co-authored-by: Abhijeet Jha <74712637+iamAbhi-916@users.noreply.github.com> Co-authored-by: Vineeth <66076509+vineethkuttan@users.noreply.github.com> Co-authored-by: Vineeth K <kvineeth@microsoft.com> Co-authored-by: Harini Malothu <harinimalothu17@gmail.com> Co-authored-by: Harini Malothu <hmalothu@microsoft.com> Co-authored-by: Chiara Mooney <34109996+chiaramooney@users.noreply.github.com> Co-authored-by: Jon Thysell <jthysell@microsoft.com> Co-authored-by: Protik Biswas <219775028+protikbiswas100@users.noreply.github.com> Co-authored-by: Protik Biswas <protikbiswas100@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes made to raise UIA Changed Event if toggle state changes.
Type of Change
Why
Changing toggle doesn't notify the UIA Clients.
Resolves [#14608]
What
Changes made to notify UIA Clients, if toggle state changes
Screenshots
ToggleStateUpdate.mp4
Testing
Tested in Playground.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow