-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react-native dependency to 0.59 #2411
Conversation
Added windows platform moniker to metro config. Temporarily removing the Alert module, follow on work to fix create the native / cross-platform alert manager based on changes to the Alert module in react-native@0.59.
Still needs some work updating references to @react-native-community/cli - cc @in4margaret, in case you have some time to take a look. |
Fixed issue with template generator, one more issue to resolve for metro in generated projects. |
doesn't Yoga also need to be synced? |
I'm tracking an upstream issue where apps for out-of-tree platforms get this error when trying to run jest tests after an upgrade to 0.59: The error is the same, but the reasons appear to be different than those mentioned in the thread. |
@matthargett good point - I'll also update yoga |
Hello @rozele! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@matthargett - on second thought - I'll time box the fixes to update to the latest Yoga, as every upgrade seems to result in breaking changes to layout. If it takes more than a couple hours, we'll ship 0.59 as is and add a backlog item to get Yoga updated. |
Ugh - seemed to be an issue with enum bitfields 🙄. Disabling those fixes the layout. |
Hi @rozele, any updates on this PR? Android is requiring 64bit builds as of Aug 1 which naturally places some time pressure on this upgrade in order to maintain platform compatibility across iOS, Android and Windows. |
Updates dependencies to match react-native@0.59, includes fixes to metro config, Alert module and updated reference to @react-native-community/cli