-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): fix cache not being used when there are no dependencies #9522
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks like Beachball is having issues again:
|
This specific one might be our fault. We have a known race condition in our CI logic that can cause PRs to fail when run around the same time as our nightly publish. It is unexpected though, since this was not close to that time. Another case where we have seen these issues is if Beachball were to run into issues during publish, and not push results to our repository, but it looks like it did correctly push that. Need to take a closer look. |
Seeing the same Beachball issue with #9491. Doing a |
I think I've identified the issue, with c3d84b0. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR backports microsoft#9522 to 0.68. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
This PR backports microsoft#9522 to 0.67. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
This PR backports microsoft#9522 to 0.66. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves microsoft#9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms |
…ies (#9549) This PR backports #9522 to 0.67. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves #9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms | Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
…ies (#9548) This PR backports #9522 to 0.68. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves #9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms | Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
…ies (#9550) This PR backports #9522 to 0.66. - Bug fix (non-breaking change which fixes an issue) This addresses a perf regression in autolinking when there are no dependencies to link. Resolves #9518 Instead of checking whether the dependencies cache is empty, check whether it was instantiated. | Before | After | | -: | -: | | 22488ms | 3561ms | Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Description
Type of Change
Why
This addresses a perf regression in autolinking when there are no dependencies to link.
Resolves #9518
What
Instead of checking whether the dependencies cache is empty, check whether it was instantiated.
Testing
Microsoft Reviewers: Open in CodeFlow