Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval_rule: Evaluate rules directly instead of queries #186

Merged
merged 1 commit into from
Mar 25, 2024
Merged

eval_rule: Evaluate rules directly instead of queries #186

merged 1 commit into from
Mar 25, 2024

Conversation

anakrish
Copy link
Collaborator

closes #185

@anakrish
eval_rule: Evaluate rules directly instead of queries
a478e00 
closes microsoft#185

Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
@anakrish anakrish merged commit 3d98c3b into microsoft:main Mar 25, 2024
4 checks passed
@anakrish anakrish deleted the eval-rule branch March 26, 2024 00:01
@anakrish
Copy link
Collaborator Author

@unexge Consider using eval_rule if possible. It is more performant than eval_query at the microsecond level.

@unexge
Copy link
Contributor

unexge commented Mar 28, 2024

Thank you @anakrish! That improved our internal benchmarks between 10% to 30% 🚀

@anakrish anakrish mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to evaluate rules directly instead of evaluating queries
2 participants
@anakrish @unexge