Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization strings in core-ui should be with prefix Localization.Core instead of Localization.Interpret #1340

Open
tongyu-microsoft opened this issue Apr 12, 2022 · 0 comments
Open

Localization strings in core-ui should be with prefix Localization.Core instead of Localization.Interpret #1340

tongyu-microsoft opened this issue Apr 12, 2022 · 0 comments

Comments

@tongyu-microsoft
Copy link
Contributor

Localization strings in core-ui wasn't moved properly when it was moved to core. For example, in CohortEditorFilter.tsx,
we shouldn't use
Localization.Interpret.CohortEditor
should be:
Localization.Core.CohortEditor.
We need to update all core related strings into Localization.Core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tongyu-microsoft