[UI refactor] Remove .bind() part2 - Remove .bind in counterfactual folder and part of .bind() in other folders #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyu-microsoft
requested review from
romanlutz,
gaugup,
xuke444,
imatiach-msft and
vinuthakaranth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1542 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 107 107
Lines 5069 5069
=======================================
Hits 4430 4430
Misses 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
xuke444
approved these changes
Jul 8, 2022
libs/error-analysis/src/lib/ErrorAnalysisDashboard/Controls/Matrix/MatrixArea/MatrixArea.tsx
Show resolved
Hide resolved
imatiach-msft
approved these changes
Jul 8, 2022
1 similar comment
1 similar comment
1 similar comment
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes .bind() in libs\counterfactuals folder. And also removes part of .bind() in core-ui, counterfactual, dataset-explorer, error-analysis folders.
Description
The UI refactor work is to remove all .bind() functions. And this PR is part 2.
part 1 PR link: #1523.
There will be following PRs to remove other .bind() functions.
The reason that we want to remove .bind() is that, a different callback is created each time the component renders. So we want to remove .bind() and set lint rule in the end to ban adding .bind() in the future.
Checklist