Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI refactor] Remove .bind() part 1 - Remove .bind(this, true/false) #1523

Merged
merged 7 commits into from
Jun 29, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

@tongyu-microsoft tongyu-microsoft commented Jun 28, 2022

This PR removes .bind(this, true/false) by separating setXOpen.bind(this, true/false) to setXOpen() and setXClose(). Same for setYOpen.

Description

The UI refactor work is to remove all .bind() functions. And this PR is part 1. There will be following PRs to remove other .bind() functions. The reason that we want to remove .bind() is that, a different callback is created each time the component renders. So we want to remove .bind() and set lint rule in the end to ban adding .bind() in the future.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #1523 (2ea3b3a) into main (b56f431) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files         108      108           
  Lines        5108     5108           
=======================================
  Hits         4458     4458           
  Misses        650      650           
Flag Coverage Δ
unittests 87.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56f431...2ea3b3a. Read the comment docs.

1 similar comment
@tongyu-microsoft tongyu-microsoft enabled auto-merge (squash) June 29, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants