-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI refactor] Remove .bind() part 1 - Remove .bind(this, true/false) #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyu-microsoft
requested review from
romanlutz,
gaugup,
xuke444 and
vinuthakaranth
as code owners
June 28, 2022 17:25
Codecov Report
@@ Coverage Diff @@
## main #1523 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 108 108
Lines 5108 5108
=======================================
Hits 4458 4458
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vinuthakaranth
approved these changes
Jun 28, 2022
1 similar comment
romanlutz
approved these changes
Jun 29, 2022
This was referenced Jul 8, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
.bind(this, true/false)
by separatingsetXOpen.bind(this, true/false)
tosetXOpen()
andsetXClose()
. Same for setYOpen.Description
The UI refactor work is to remove all .bind() functions. And this PR is part 1. There will be following PRs to remove other .bind() functions. The reason that we want to remove .bind() is that, a different callback is created each time the component renders. So we want to remove .bind() and set lint rule in the end to ban adding .bind() in the future.
Checklist