[UI refactor] Remove .bind() part3 - Remove .bind for SpinButton in AxisConfigDialog, MultiICEPlot and Fairness #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongyu-microsoft
requested review from
romanlutz,
xuke444,
vinuthakaranth and
gaugup
as code owners
tongyu-microsoft
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1555 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 109 109
Lines 5271 5271
=======================================
Hits 4638 4638
Misses 633 633
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1 similar comment
imatiach-msft
approved these changes
Jul 14, 2022
RubyZ10
reviewed
Jul 14, 2022
RubyZ10
approved these changes
Jul 14, 2022
RubyZ10
approved these changes
Jul 14, 2022
…responsible-ai-widgets into tongy/removeBindPart3
1 similar comment
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes .bind() for SpinButton in AxisConfigDialog, MultiICEPlot and Fairness folder. Also removes .bind() for cohortList by creating a cohortNameColumn component.
Description
The UI refactor work is to remove all .bind() functions. And this PR is part 3.
part 1 PR link: #1523.
part 2 PR link: #1542.
There will be following PRs to remove other .bind() functions.
The reason that we want to remove .bind() is that, a different callback is created each time the component renders. So we want to remove .bind() and set lint rule in the end to ban adding .bind() in the future.
Checklist