Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove widget tests from CI-notebook pipeline #1213

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

vinuthakaranth
Copy link
Contributor

Remove widget tests from CI-notebook pipeline

Description

Remove widget tests from CI-notebook pipeline as it is already present in ci-raiwidgets-python-typescript pipeline

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #1213 (ddf013e) into main (1bbe14c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          91       91           
  Lines        4379     4379           
=======================================
  Hits         2938     2938           
  Misses       1441     1441           
Flag Coverage Δ
unittests 67.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbe14c...ddf013e. Read the comment docs.

1 similar comment
@imatiach-msft
Copy link
Contributor

this PR is still marked as a draft?

1 similar comment
@vinuthakaranth vinuthakaranth marked this pull request as ready for review February 10, 2022 21:27
@vinuthakaranth vinuthakaranth merged commit 6bfdfce into main Feb 10, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/removeWidgetsFromnotebook branch February 10, 2022 21:28
gaugup pushed a commit that referenced this pull request Feb 27, 2022
* remove widget

* add log

* remove log

* fix name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants