Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing release steps causing rai-core-flask release errors #1216

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

imatiach-msft
Copy link
Contributor

Description

Add missing release steps causing rai-core-flask release errors.
When I tried to release rai-core-flask package to pypi, I got the error:

error: invalid command 'bdist_wheel'
Error: Process completed with exit code 1.

See build:
https://github.com/microsoft/responsible-ai-toolbox/runs/5145702921?check_suite_focus=true

We are clearly missing the step to install wheel package. I also noticed this is missing from error analysis release pipeline as well, which was added based on rai-core-flask pipeline.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1216 (3d6a10a) into main (1bbe14c) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d6a10a differs from pull request most recent head 9248923. Consider uploading reports for the commit 9248923 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          91       91           
  Lines        4379     4379           
=======================================
  Hits         2938     2938           
  Misses       1441     1441           
Flag Coverage Δ
unittests 67.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbe14c...9248923. Read the comment docs.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-release-steps branch from 3d6a10a to 9248923 Compare February 10, 2022 19:09
1 similar comment
@imatiach-msft imatiach-msft merged commit b7bd2af into main Feb 11, 2022
@imatiach-msft imatiach-msft deleted the ilmat/fix-release-steps branch February 11, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants