-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data validations to SDK defined cohorts #1227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
imatiach-msft,
xuke444,
zhb000,
vinuthakaranth,
tongyu-microsoft and
romanlutz
as code owners
February 15, 2022 09:10
Codecov Report
@@ Coverage Diff @@
## main #1227 +/- ##
==========================================
- Coverage 67.19% 65.99% -1.21%
==========================================
Files 91 91
Lines 4393 4473 +80
==========================================
Hits 2952 2952
- Misses 1441 1521 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imatiach-msft
approved these changes
Feb 16, 2022
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
1 similar comment
gaugup
added a commit
that referenced
this pull request
Feb 27, 2022
* Add data validations to SDK defined cohorts Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Fix code review comments Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following validations need to be performed for cohort filter with
test data:-
High level validations
list.
"Index" Filter validations
filter method.
"Classification Outcome" Filter validations
multiclass classification and regression.
ClassificationOutcomes.
CohortFilterMethods.INCLUDES filter method.
"Error" Filter validations
multiclass classification and binary classification.
filter methods cannot be configured for this filter.
"Predicted Y/True Y" Filter validations
superset of the classes available in the test data.
configured for "Predicted Y" filter in case of classification.
filter methods cannot be configured for this filter for regression.
"Dataset" Filter validations
should be within the range of minimum and maximum values available
within the continuous feature column in the test data.
configured.
the values available in the categorical column in the test data.
Areas changed
npm packages changed:
Python packages changed:
Tests
Screenshots (if appropriate):
Documentation: