Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ut for DashboardSettingDeleteButton #1231

Merged
merged 5 commits into from
Feb 22, 2022
Merged

add ut for DashboardSettingDeleteButton #1231

merged 5 commits into from
Feb 22, 2022

Conversation

xuke444
Copy link
Collaborator

@xuke444 xuke444 commented Feb 16, 2022

Signed-off-by: Ke Xu xuke@microsoft.com

Description

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: Ke Xu <xuke@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

Merging #1231 (3f2a6e7) into main (9578d5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files          10       10           
  Lines         258      258           
=======================================
  Hits          195      195           
  Misses         63       63           
Flag Coverage Δ
unittests 75.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9578d5a...3f2a6e7. Read the comment docs.

Signed-off-by: Ke Xu <xuke@microsoft.com>
xuke444 and others added 3 commits February 18, 2022 13:51
Signed-off-by: Ke Xu <xuke@microsoft.com>
Signed-off-by: Ke Xu <xuke@microsoft.com>
@xuke444 xuke444 merged commit f3b3fe1 into main Feb 22, 2022
@xuke444 xuke444 deleted the xuke/addut branch February 22, 2022 18:32
gaugup pushed a commit that referenced this pull request Feb 27, 2022
* add ut for DashboardSettingDeleteButton 
force merge due to python pipeline failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants