Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pytest fixtures raiwidgets tests #1232

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Feb 17, 2022

Description

The RAIInsights computation logic can be refactored into pytest fixture so that multiple tests in raiwidgets can leverage the computed RAIInsights.

Areas changed

npm packages changed:

  • responsibleai/causality
  • responsibleai/core-ui
  • responsibleai/counterfactuals
  • responsibleai/dataset-explorer
  • responsibleai/fairness
  • responsibleai/interpret
  • responsibleai/localization
  • responsibleai/mlchartlib
  • responsibleai/model-assessment

Python packages changed:

  • raiwidgets
  • responsibleai
  • erroranalysis
  • rai_core_flask

Tests

  • No new tests required.
  • New tests for the added feature are part of this PR.
  • I validated the changes manually.

Screenshots (if appropriate):

Documentation:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #1232 (9cef48c) into main (4185c9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1232   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          91       91           
  Lines        4475     4475           
=======================================
  Hits         2954     2954           
  Misses       1521     1521           
Flag Coverage Δ
unittests 66.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4185c9f...9cef48c. Read the comment docs.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) February 18, 2022 12:15
@gaugup gaugup merged commit 631b220 into main Feb 23, 2022
@gaugup gaugup deleted the gaugup/CreatePytestFixturesRaiWidgetsTests branch February 23, 2022 04:27
gaugup added a commit that referenced this pull request Feb 23, 2022
* Create pytest fixtures raiwidgets tests

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Remove unused imports

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup added a commit that referenced this pull request Feb 24, 2022
* Add pre-built cohort injection logic into raiwidgets

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* add conftest.py

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Create pytest fixtures raiwidgets tests (#1232)

* Create pytest fixtures raiwidgets tests

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Remove unused imports

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Fix sorted imports

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup added a commit that referenced this pull request Feb 27, 2022
* Create pytest fixtures raiwidgets tests

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Remove unused imports

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup added a commit that referenced this pull request Feb 27, 2022
* Add pre-built cohort injection logic into raiwidgets

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* add conftest.py

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Create pytest fixtures raiwidgets tests (#1232)

* Create pytest fixtures raiwidgets tests

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Remove unused imports

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Fix sorted imports

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants