Pin markupsafe and itsdangerous to unblock gates #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
- Coverage 75.58% 66.01% -9.58%
==========================================
Files 10 91 +81
Lines 258 4475 +4217
==========================================
+ Hits 195 2954 +2759
- Misses 63 1521 +1458
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gaugup
requested review from
imatiach-msft,
riedgar-ms,
xuke444 and
kicha0
as code owners
imatiach-msft
approved these changes
Feb 21, 2022
riedgar-ms
approved these changes
Feb 21, 2022
gaugup
requested review from
zhb000,
vinuthakaranth,
tongyu-microsoft and
romanlutz
as code owners
gaugup
changed the title
gaugup
added a commit
that referenced
this pull request
Feb 27, 2022
* Pin markupsafe to unblock gates * Update requirements.txt * Pin itsdangerous at 2.0.1 to address another dependency failure * Update requirements.txt * Update requirements.txt
19 tasks
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There seem to be multiple dependency problems with few gate pipelines in responsible-ai-toolbox.
File "/usr/share/miniconda/envs/test/bin/jupyter-nbconvert", line 5, in
21 from nbconvert.nbconvertapp import main
22 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/nbconvert/init.py", line 4, in
23 from .exporters import *
24 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/nbconvert/exporters/init.py", line 3, in
25 from .html import HTMLExporter
26 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/nbconvert/exporters/html.py", line 16, in
27 import jinja2
28 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/jinja2/init.py", line 12, in
29 from .environment import Environment
30 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/jinja2/environment.py", line 25, in
31 from .defaults import BLOCK_END_STRING
32 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/jinja2/defaults.py", line 3, in
33 from .filters import FILTERS as DEFAULT_FILTERS # noqa: F401
34 File "/usr/share/miniconda/envs/test/lib/python3.7/site-packages/jinja2/filters.py", line 13, in
35 from markupsafe import soft_unicode
36ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/usr/share/miniconda/envs/test/lib/python3.7/site-packages/markupsafe/init.py)
37Existing e2e
tests/test_flask_helper.py:10: in
250 from rai_core_flask import FlaskHelper
251rai_core_flask/init.py:6: in
252 from .flask_helper import FlaskHelper
253rai_core_flask/flask_helper.py:11: in
254 from flask import Flask
255/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/init.py:14: in
256 from jinja2 import escape
257/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/jinja2/init.py:12: in
258 from .environment import Environment
259/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/jinja2/environment.py:25: in
260 from .defaults import BLOCK_END_STRING
261/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/jinja2/defaults.py:3: in
262 from .filters import FILTERS as DEFAULT_FILTERS # noqa: F401
263/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/jinja2/filters.py:13: in
264 from markupsafe import soft_unicode
265E ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/markupsafe/init.py)
There seem to be two failures in different paths. As solution, I am pinning markupsafe in both raiwidgets and rai_core_flask.
ImportError while importing test module '/home/runner/work/responsible-ai-toolbox/responsible-ai-toolbox/raiwidgets/tests/test_cohort.py'.
27Hint: make sure your test modules/packages have valid Python names.
28Traceback:
29raiwidgets/tests/test_cohort.py:9: in
30 from raiwidgets._cohort import (ClassificationOutcomes, Cohort, CohortFilter,
31/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/raiwidgets/init.py:7: in
32 from .error_analysis_dashboard import ErrorAnalysisDashboard
33/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/raiwidgets/error_analysis_dashboard.py:6: in
34 from flask import jsonify, request
35/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/init.py:21: in
36 from .app import Flask, Request, Response
37/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/app.py:26: in
38 from . import cli, json
39/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/flask/json/init.py:21: in
40 from itsdangerous import json as _json
41E ImportError: cannot import name 'json' from 'itsdangerous' (/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/itsdangerous/init.py)
The solution is to pin itsdangerous package to 2.0.1.
Areas changed
npm packages changed:
Python packages changed:
Tests
Screenshots (if appropriate):
Documentation: