Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part 2: add pyspark support to tree surrogate model in error analysis #1388

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented May 5, 2022

Description

This is a follow-up PR to #1251. This PR includes the ErrorAnalysisDashboard changes to add pyspark support to error analysis. This will allow users to run ErrorAnalysisDashboard in Azure Synapse or Databricks as a widget using the lightgbm model from https://github.com/microsoft/SynapseML/ as the surrogate model for computing the decision tree trained on errors which is shown in the dashboard on large, TB size data.

image

Checklist

  • I have added screenshots above for all UI changes.
  • Documentation was updated if it was needed.
  • New tests were added or changes were manually verified.

@imatiach-msft imatiach-msft force-pushed the ilmat/ea-spark branch 3 times, most recently from 8fb785d to c7fe0b6 Compare May 5, 2022 22:16
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #1388 (bb91a46) into main (1a54cb0) will increase coverage by 5.10%.
The diff coverage is 67.60%.

@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
+ Coverage   82.16%   87.27%   +5.10%     
==========================================
  Files          31      108      +77     
  Lines        1402     5108    +3706     
==========================================
+ Hits         1152     4458    +3306     
- Misses        250      650     +400     
Flag Coverage Δ
unittests 87.27% <67.60%> (+5.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dgets/raiwidgets/error_analysis_dashboard_input.py 66.21% <67.60%> (-3.34%) ⬇️
responsibleai/responsibleai/_managers/__init__.py 100.00% <0.00%> (ø)
.../responsibleai/modelanalysis/constants/__init__.py 100.00% <0.00%> (ø)
..._core_flask/environments/databricks_environment.py 56.25% <0.00%> (ø)
...sponsibleai/responsibleai/rai_insights/__init__.py 100.00% <0.00%> (ø)
erroranalysis/erroranalysis/analyzer/__init__.py 100.00% <0.00%> (ø)
responsibleai/responsibleai/_internal/constants.py 100.00% <0.00%> (ø)
...core_flask/rai_core_flask/environments/__init__.py 100.00% <0.00%> (ø)
...re_flask/environments/local_ipython_environment.py 88.88% <0.00%> (ø)
rai_core_flask/rai_core_flask/__init__.py 100.00% <0.00%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a54cb0...bb91a46. Read the comment docs.

3 similar comments
@xuke444
Copy link
Collaborator

xuke444 commented May 6, 2022

Is this for Synapse and/or databricks only?
Let's hold this to post build, to freeze the sdk version for build for now.

@imatiach-msft
Copy link
Contributor Author

yes, it is for synapse/databricks support only

1 similar comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants