Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model overview: improve placeholder, put confirm/cancel buttons at the bottom, and hide toggle when needed #1433

Merged
merged 24 commits into from
May 18, 2022
Merged

Model overview: improve placeholder, put confirm/cancel buttons at the bottom, and hide toggle when needed #1433

merged 24 commits into from
May 18, 2022

Conversation

romanlutz
Copy link
Contributor

This is identical to #1414 but targeting the postbuild branch.

Description

This PR includes a series of small improvements based on our recent bug bash:

  • removed ActionButton and replaced it with a proper placeholder for the missing table
    image

  • moved confirm/cancel buttons to the bottom of flyouts
    imageimageimage

  • don't show toggle unless needed

    • show toggle when there are multiple cohorts
      image
    • don't show toggle with only 1 cohort
      image
    • don't show toggle without features selected
      image
    • show toggle with features selected
      image

  • fix "placolder" typo in the code (no visible changes)

Checklist

  • I have added screenshots above for all UI changes.
  • Documentation was updated if it was needed.
  • New tests were added or changes were manually verified.

romanlutz and others added 21 commits May 10, 2022 01:51
@romanlutz
improved placeholder, removed action button, confirm/cancel buttons a…
f93db18 
…t bottom of flyouts, don't show toggle unless needed
@romanlutz
fix toggle behavior
fad6e93
@romanlutz
center placeholder text
bc20c6a
@romanlutz
lint
f26c19a
@romanlutz
Merge branch 'main' into romanlutz/bugfixes
911c75d
@imatiach-msft
fix error on machines with pyspark installed where passed dataframe i…
d0047f1 
…s not spark pandas (#1415)
@romanlutz
add postbuild branch trigger (#1417)
a4a46d5
@gaugup
Fix causal UI strings according to classification/regression tasks (#…
c53ba4d 
…1419)

* Fix causal UI strings according to classification/regression tasks

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Fix lint error

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Fix UI test

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@romanlutz
Merge branch 'main' into romanlutz/bugfixes
deb75d1
@romanlutz
Fix description for model overview (#1425)
fb5c769 
* fix description for model overview

* keep new description for new model overview
@romanlutz
Merge branch 'main' into romanlutz/bugfixes
503ee62
@imatiach-msft
fix failing to create error report when filter_features is empty list (…
29b57af 
…#1421)
@imatiach-msft
filter out missing values from what if dropdown to prevent explanatio…
4f1e262 
…n dashboard from crashing (#1418)
@gaugup
Remove |Set Value| blurb in case it is not availble in counterfactual…
cf3c25b 
… panel (#1426)

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup @xuke444
Add y-axis description to counterfactual feature importance chart (#1423
42a495c 
)

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

Co-authored-by: xuke444 <40614413+xuke444@users.noreply.github.com>
@gaugup @xuke444
Add the user class name to causal UI strings (#1422)
839f2ae 
* Fix causal UI strings according to classification/regression tasks

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Fix lint error

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Fix UI test

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Add the user class name to causal UI strings

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

Co-authored-by: xuke444 <40614413+xuke444@users.noreply.github.com>
@xuke444
fix math.min / max for array size more than 10^7 (#1427)
bc7a9f9 
Signed-off-by: Ke Xu <xuke@microsoft.com>
@romanlutz
Merge branch 'main' into romanlutz/bugfixes
23a6dbf
@imatiach-msft
upgrade pytest and lightgbm to try to fix random pytest segfault test…
8c4ce56 
… failures (#1424)

s
@imatiach-msft
fix flaky notebook causing build failures by adding retry logic (#1431)
b982016
@romanlutz
Merge branch 'main' into romanlutz/bugfixes
6ceffb9
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022 •
edited
Loading

Codecov Report

Merging #1433 (bdb64ce) into postbuild (0f3746b) will decrease coverage by 3.40%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           postbuild    #1433      +/-   ##
=============================================
- Coverage      89.34%   85.94%   -3.41%     
=============================================
  Files             80      100      +20     
  Lines           3556     4801    +1245     
=============================================
+ Hits            3177     4126     +949     
- Misses           379      675     +296
Flag Coverage Δ
unittests 85.94% <ø> (-3.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raiwidgets/raiwidgets/interfaces.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/__init__.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/explanation_dashboard.py 83.33% <0.00%> (ø)
...iwidgets/raiwidgets/explanation_dashboard_input.py 60.13% <0.00%> (ø)
raiwidgets/raiwidgets/cohort.py 95.00% <0.00%> (ø)
raiwidgets/raiwidgets/error_analysis_constants.py 100.00% <0.00%> (ø)
raiwidgets/raiwidgets/dashboard.py 92.68% <0.00%> (ø)
raiwidgets/raiwidgets/error_handling.py 75.00% <0.00%> (ø)
raiwidgets/raiwidgets/utils.py 100.00% <0.00%> (ø)
...iwidgets/raiwidgets/model_performance_dashboard.py 50.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3746b...bdb64ce. Read the comment docs.

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/bugfixes/dashboard/index.html

@romanlutz romanlutz mentioned this pull request May 17, 2022
Closed
3 tasks
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/bugfixes/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/bugfixes/dashboard/index.html

@romanlutz romanlutz merged commit d3591af into postbuild May 18, 2022
@romanlutz romanlutz deleted the romanlutz/bugfixes branch May 18, 2022 02:42
This was referenced Jun 9, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuke444 xuke444 xuke444 approved these changes

@vinuthakaranth vinuthakaranth vinuthakaranth approved these changes

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@gaugup gaugup Awaiting requested review from gaugup

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romanlutz @codecov-commenter @imatiach-msft @vinuthakaranth @xuke444 @gaugup