-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] HeatmapHighChart: Prioritize configOverride over defaultOptions #1490
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
=======================================
Coverage 89.30% 89.30%
=======================================
Files 38 38
Lines 1617 1617
=======================================
Hits 1444 1444
Misses 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for recreating it!
Note: Recreating PR #1457 with signed commits.
Description
Context
When trying to create a heatmap using
HeatmapHighChart
, I had setlegend: { enabled : true }
but I was not seeing the legend in the heatmap.It turns out that
lodash.merge
prioritizes values from right to left. Therefore, we should specifyconfigOverride
last since we want its values to be prioritzed overdefaultOptions
.Showcasing bug
Original code:
Showcasing fix
Fix (swap
configOverride
anddefaultOptions
):Checklist