Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder controls in data explorer legend #1493

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

tongyu-microsoft
Copy link
Contributor

This PR reorders controls in data explorer legend. Keep Chart type controls at the top instead of moving it below "Color value" legend once user switches to "Individual Datapoints". So that order of control won't change between aggregate and individual views.

Description

Before:
image

After (the order of "Color value" and "Chart type" is changed):
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #1493 (e2da462) into main (9342c46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files          90       90           
  Lines        3848     3848           
=======================================
  Hits         3460     3460           
  Misses        388      388           
Flag Coverage Δ
unittests 89.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9342c46...e2da462. Read the comment docs.

@tongyu-microsoft tongyu-microsoft enabled auto-merge (squash) June 13, 2022 19:12
@tongyu-microsoft tongyu-microsoft merged commit 720cb76 into main Jun 13, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/chartType branch June 13, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants