[office-ui upgrade] Move ChoiceGroup & all other remaining dependencies to fluentui #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olbox into vikarant/officeUIUpgradefairness
…/microsoft/responsible-ai-toolbox into vikarant/officeUIUpgrademodelAssessmlchart
…olbox into vikarant/officeUIUpgrademodelAssessmlchart
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
…olbox into vikarant/officeUIUpgrademodelAssessmlchart
…github.com/microsoft/responsible-ai-toolbox into vikarant/officeUIUpgrademodelAssessmlchart
…olbox into vikarant/officeUIChoiceGroupFix
…github.com/microsoft/responsible-ai-toolbox into vikarant/officeUIChoiceGroupFix
…olbox into vikarant/officeUIChoiceGroupFix
…github.com/microsoft/responsible-ai-toolbox into vikarant/officeUIChoiceGroupFix
Codecov Report
@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 108 108
Lines 5081 5081
=======================================
Hits 4449 4449
Misses 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vinuthakaranth
changed the title
vinuthakaranth
requested review from
romanlutz,
gaugup and
xuke444
as code owners
tongyu-microsoft
approved these changes
Jun 14, 2022
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
…olbox into vikarant/officeUIChoiceGroupFix
…microsoft/responsible-ai-toolbox into vikarant/officeUIChoiceGroupFix
xuke444
approved these changes
Jun 15, 2022
xuke444
approved these changes
Jun 15, 2022
romanlutz
approved these changes
Jun 15, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove office-ui-fabric-react dependency in code repo.
Move ChoiceGroup & all other remaining dependencies to fluentui.
Due to ChoiceGroup behavior change in fluetui (undefined cannot be used as a selectedKey), as a workaround/fix we auto-select Index for user when the panel opens. This will still maintain the behavior of user cannot create cohort if filter is not selected. In turn this change reduces 1 click for user (if user wanted to select Index). If not, number of clicks will still remain same.
Checklist