Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model overview: wrap text after max line width #1503

Merged
merged 6 commits into from
Jun 16, 2022

Conversation

romanlutz
Copy link
Contributor

@romanlutz romanlutz commented Jun 15, 2022

Description

This PR wraps the remaining few occurrences of text that goes beyond the max line width (see screenshot):

image

Before it was like this without zooming in (while it did already wrap when zooming in further). That looked inconsistent since the description text before does wrap after the max width.

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@romanlutz romanlutz requested a review from xuke444 as a code owner June 15, 2022 19:50
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #1503 (6d2af53) into main (75afdc5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1503   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         108      108           
  Lines        5081     5081           
=======================================
  Hits         4449     4449           
  Misses        632      632           
Flag Coverage Δ
unittests 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75afdc5...6d2af53. Read the comment docs.

1 similar comment
@romanlutz romanlutz enabled auto-merge (squash) June 16, 2022 04:01
@romanlutz romanlutz merged commit addf2a0 into main Jun 16, 2022
@romanlutz romanlutz deleted the romanlutz/model_overview_text_wrap branch June 16, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants