Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade highcharts from v9.3.0 to v10.1.0, remove highcharts bundle by setting it to external module #1506

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

This PR upgrades highcharts from v9.3.0 to v10.1.0, removes highcharts bundle by setting it to external module.

Description

The reason we want to upgrade highcharts version is, there is a bug on v9.3.0 where exporting svg file is broken. This bug is fixed after v10.0.0. So here we upgrade highcharts to 10.1.0.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #1506 (f98fa88) into main (785422e) will increase coverage by 1.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   87.56%   89.30%   +1.73%     
==========================================
  Files         108       38      -70     
  Lines        5081     1617    -3464     
==========================================
- Hits         4449     1444    -3005     
+ Misses        632      173     -459     
Flag Coverage Δ
unittests 89.30% <ø> (+1.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dgets/raiwidgets/error_analysis_dashboard_input.py
...i/responsibleai/managers/error_analysis_manager.py
raiwidgets/raiwidgets/explanation_constants.py
...ibleai/_tools/causal/dashboard_schemas/__init__.py
raiwidgets/raiwidgets/explanation_dashboard.py
raiwidgets/raiwidgets/error_handling.py
...bleai/responsibleai/_tools/causal/causal_config.py
...ai/databalanceanalysis/feature_balance_measures.py
responsibleai/responsibleai/exceptions.py
raiwidgets/raiwidgets/error_analysis_constants.py
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785422e...f98fa88. Read the comment docs.

1 similar comment
@tongyu-microsoft tongyu-microsoft merged commit 587c1ec into main Jun 17, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/upgradeHighcharts branch June 17, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants