Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derandomize notebooks #1507

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Derandomize notebooks #1507

merged 1 commit into from
Jun 17, 2022

Conversation

romanlutz
Copy link
Contributor

@romanlutz romanlutz commented Jun 17, 2022

Description

Our notebooks (with one exception) all use randomized ML techniques, meaning the trained model is different in every single execution. This makes testing somewhat difficult to impossible (as we'd be restricted to test for only the things that remain constant). To fix this, I added random_state and set it to a constant, and for the pytorch notebook I set a manual seed. Note that this doesn't affect the user experience. Users can always choose to delete this or change the random seed, of course.

This is another PR that was part of #1467 but is now separate to simplify #1467

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@romanlutz romanlutz requested a review from imatiach-msft June 17, 2022 16:47
@codecov-commenter
Copy link

Codecov Report

Merging #1507 (64f376d) into main (587c1ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1507   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         108      108           
  Lines        5081     5081           
=======================================
  Hits         4449     4449           
  Misses        632      632           
Flag Coverage Δ
unittests 87.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587c1ec...64f376d. Read the comment docs.

@romanlutz romanlutz merged commit b23449a into main Jun 17, 2022
@romanlutz romanlutz deleted the romanlutz/derandomize_notebooks branch June 17, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants