Model overview: new cohorts should show up #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
xuke444,
tongyu-microsoft and
vinuthakaranth
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 108 108
Lines 5108 5108
=======================================
Hits 4458 4458
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Will e2e tests be added in later PR? |
vinuthakaranth
approved these changes
Jun 27, 2022
tongyu-microsoft
approved these changes
Jun 27, 2022
...essment/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ChartConfigurationFlyout.tsx
Outdated
Show resolved
Hide resolved
No. It's a really good point. I added them and promptly discovered a bug! Thanks for the suggestion. |
3 similar comments
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, newly added cohorts showed up in the table/heatmap, but not in the chart below. This is because we have a configuration panel for this cohort selection and new cohorts were treated like the unselected cohorts as the panel wasn't aware of the difference. This PR changes this and auto-selects new cohorts for the charts.
Old behavior:
Dashboard.-.Google.Chrome.2022-06-24.17-17-52.mp4
New behavior:
Dashboard.-.Google.Chrome.2022-06-24.17-13-17.mp4
Checklist