-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add License and Requirements to Source Distribtion #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @janjagusch ! This looks fine to me. @xuke444 @imatiach-msft ?
Codecov Report
@@ Coverage Diff @@
## main #1522 +/- ##
=======================================
Coverage 87.27% 87.27%
=======================================
Files 108 108
Lines 5108 5108
=======================================
Hits 4458 4458
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
FWIW we'll have to override the failing CD build since the secret isn't available for people with their own forks (which is also something we should fix at some point). Since there are no real code changes I'm not worried about that, though. |
@janjagusch do you need us to do another pypi release, or are you all set to add those packages to conda-forge? |
FYI I force-merged this PR due to the CD build failing, I think this is something that we really need to resolve as soon as possible for those who contribute from forks as it's something that has come up numerous times |
Thanks for merging @imatiach-msft! If you could release new versions, that would be great. I can work around the missing files, but this way to build would be much easier. Thanks a lot! |
Description
Hi!
We're currently making an effort to put the responsible-ai-toolbox on conda-forge. You can find the corresponding PRs here:
We've noticed that there are some files missing in the source distribution that you ship on PyPI.
requirements.txt
file is missing, which is read inside thesetup.py
(example)Adding the
requirements.txt
to the source distribution can be accomplished by adding aMANIFEST.in
file to the root of the package repository. As there is no way to reference files outside the root of the repository when building a source distribution (source), we had to copy the license file into all package directories. We also made sure that thedist/
directory does not get committed to version control when testing this.Checklist