Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel buttons should be uniform: change all buttons to "Apply"; all buttons should be at bottom #1524

Merged
merged 11 commits into from
Jun 29, 2022

Conversation

tongyu-microsoft
Copy link
Contributor

@tongyu-microsoft tongyu-microsoft commented Jun 28, 2022

This PR updates all panel buttons include "Select", "Confirm", "Apply" to "Apply"; all buttons stays at the bottom.

Description

  1. feature list:
    Before:
    image

After:
image

  1. Axis value selection panel:
    Before:
    image

After:
image

  1. new model overview:
    Before:
    image

After:
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #1524 (4ba19fb) into main (8be72b5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files         108      108           
  Lines        5108     5108           
=======================================
  Hits         4458     4458           
  Misses        650      650           
Flag Coverage Δ
unittests 87.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be72b5...4ba19fb. Read the comment docs.

4 similar comments
1 similar comment
@tongyu-microsoft tongyu-microsoft enabled auto-merge (squash) June 29, 2022 19:17
@tongyu-microsoft tongyu-microsoft merged commit 94dd072 into main Jun 29, 2022
@tongyu-microsoft tongyu-microsoft deleted the tongy/panelButtons branch June 29, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants