Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e-widget.js for the case without flight argument #1529

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

romanlutz
Copy link
Contributor

Description

Recently, e2e-widget.js was updated to allow for passing flights via -f. This works either with or without args for -f as it's used by the GitHub workflow. However, users can just as well call the script without -f at all. Currently, this leads to an error as we're calling .toString() on the argument which would be undefined. This change ensures that we don't do that while still mapping both cases of not specifying flights (either with -f and no extra args, or without -f) to flights as undefined.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #1529 (98b8ec9) into main (0a4f296) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files         108      108           
  Lines        5108     5108           
=======================================
  Hits         4458     4458           
  Misses        650      650           
Flag Coverage Δ
unittests 87.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4f296...98b8ec9. Read the comment docs.

@romanlutz romanlutz enabled auto-merge (squash) July 1, 2022 05:28
@romanlutz romanlutz requested a review from vinuthakaranth July 1, 2022 05:28
@romanlutz romanlutz merged commit 9b14e05 into main Jul 1, 2022
@romanlutz romanlutz deleted the romanlutz/fix_e2e_widget_script branch July 1, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants