Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the local point selection drop down consistent in causal and counterfactual #1539

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 7, 2022

Description

Before
Causal
image

Counterfactual
image

After
Causal
image

Counterfactual
image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

…nterfactual

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #1539 (e274a57) into main (c5c5c80) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1539   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         107      107           
  Lines        5040     5040           
=======================================
  Hits         4401     4401           
  Misses        639      639           
Flag Coverage Δ
unittests 87.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c5c80...e274a57. Read the comment docs.

@gaugup gaugup merged commit 30bfe87 into main Jul 8, 2022
@gaugup gaugup deleted the gaugup/ChangeCausalLocalPointSelection branch July 8, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants