Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column and feature range meta data to meta file #1541

Merged
merged 15 commits into from
Jul 9, 2022

Conversation

vinuthakaranth
Copy link
Contributor

Add column and feature range meta data to meta file to help UI get these values in data explorer step of score card generation.

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
…olbox into vikarant/addFeaturesMeta

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #1541 (ffc29b1) into main (30bfe87) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
+ Coverage   87.32%   87.39%   +0.07%     
==========================================
  Files         107      107              
  Lines        5040     5069      +29     
==========================================
+ Hits         4401     4430      +29     
  Misses        639      639              
Flag Coverage Δ
unittests 87.39% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 75.46% <100.00%> (+2.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30bfe87...ffc29b1. Read the comment docs.

@imatiach-msft
Copy link
Contributor

imatiach-msft commented Jul 8, 2022

@vinuthakaranth FYI it looks like there are some minor flake8 style issues causing python linting step to fail:

./responsibleai/responsibleai/rai_insights/rai_insights.py:43:13: E225 missing whitespace around operator
./responsibleai/responsibleai/rai_insights/rai_insights.py:546:1: W293 blank line contains whitespace

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth vinuthakaranth enabled auto-merge (squash) July 9, 2022 00:46
@vinuthakaranth vinuthakaranth merged commit 6b6e1fb into main Jul 9, 2022
@vinuthakaranth vinuthakaranth deleted the vikarant/addFeaturesMeta branch July 9, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants