Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID to counterfactual config and serialized counterfactual data #1553

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jul 13, 2022

Description

This will enable querying for counterfactuals from UI. UI can pass the id using which we will be able to look up the counterfactual config / explainer using which we can generate the counterfactuals.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #1553 (87608bc) into main (384c5b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1553   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          57       57           
  Lines        2877     2877           
=======================================
  Hits         2449     2449           
  Misses        428      428           
Flag Coverage Δ
unittests 85.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384c5b2...87608bc. Read the comment docs.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup added 2 commits July 14, 2022 10:20
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup enabled auto-merge (squash) July 14, 2022 17:33
@gaugup gaugup merged commit 22ede53 into main Jul 14, 2022
@gaugup gaugup deleted the gaugup/AddIDToCFConfig branch July 14, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants